Skip to content

Add Sercom defs for SPI and Wire in variant #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 19, 2015

Conversation

aethaniel
Copy link
Contributor

This PR allows people working on their own SAMD21 based variant to use different Sercom for either SPI or Wire.

This PR solves the two concerns pointed in #3

Contains 5 atomic commits.

@aethaniel
Copy link
Contributor Author

@smkkHw, @cpino, this PR implies a quick update of ASME variant.
I can do it if you don't have time.

@smkkHw
Copy link

smkkHw commented Aug 11, 2015

YEs sure, Thank.

aethaniel added a commit to aethaniel/sme-arduino-core that referenced this pull request Aug 12, 2015
@aethaniel
Copy link
Contributor Author

@smkkHw, PR done here: ameltech/sme-arduino-core#4

@cmaglie cmaglie self-assigned this Aug 13, 2015
@cmaglie cmaglie added this to the Release 1.6.2 milestone Aug 13, 2015
@cmaglie
Copy link
Member

cmaglie commented Aug 13, 2015

@aethaniel has added two commits with defaults for SPI and Wire, so updating the Zero core will not break derivatives.

@cmaglie
Copy link
Member

cmaglie commented Aug 13, 2015

@ArduinoBot build this please

@ArduinoBot
Copy link

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/samd/package_samd-b23_index.json

ℹ️ To test this build:

  1. Open the Preferences of the Arduino IDE.
  2. Add the Build URL above in the Additional Boards Manager URLs field, and click OK.
  3. Open the Boards Manager (menu Tools->Board->Board Manager...)
  4. Install Arduino SAMD core - Pull Request Add Sercom defs for SPI and Wire in variant #24
  5. Select one of the boards under SAMD Pull Request Add Sercom defs for SPI and Wire in variant #24 in Tools->Board menu
  6. Compile/Upload as usual

@smkkHw
Copy link

smkkHw commented Aug 18, 2015

Tested with SmartEverything Fox.
The two examples work as expected:

  1. SigFox Example test the internal ASME Usart
  2. NFC Example uses the I2C Bus

@pixelpixi
Copy link
Contributor

I tested mapping Wire to SERCOM0 in my board's variant. Works great, thanks!

@cmaglie cmaglie merged commit 9888e64 into arduino:master Aug 19, 2015
@cmaglie cmaglie mentioned this pull request Sep 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants